go/packages: add GOROOT env to avoid TestTarget failure in OpenBSD #552

linsite · 2024-12-27T10:07:31Z

When running tests in OpenBSD if 'go' is built with -trimpath,
the TestTarget will always fail. Because when invoked without
proper environments, 'go' itself fails to find the GOROOT path.

Fixes golang/go#70891

linsite · 2024-12-27T10:08:54Z

Fixing golang/go#70891.

gopherbot · 2024-12-27T10:22:05Z

This PR (HEAD: 4f9dda5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/637961.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-27T10:30:12Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/637961.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-27T10:51:30Z

This PR (HEAD: 9bb9bc1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/637961.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-27T10:59:39Z

This PR (HEAD: a190875) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/637961.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-27T11:16:10Z

This PR (HEAD: 9807469) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/637961.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-27T11:24:27Z

This PR (HEAD: 747c2a0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/637961.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-27T11:32:28Z

Message from 蔺林:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/637961.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-31T01:17:31Z

Message from Michael Matloob:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/637961.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-31T09:15:25Z

This PR (HEAD: 33df413) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/637961.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-31T09:40:25Z

Message from 蔺林:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/637961.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-02T15:46:28Z

Message from Michael Matloob:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/637961.
After addressing review feedback, remember to publish your drafts!

When running tests in OpenBSD if 'go' is built with -trimpath, the TestTarget will always fail. Because when invoked without proper environments, 'go' itself fails to find the GOROOT path. Fixes golang/go#70891

gopherbot · 2025-01-03T00:27:44Z

This PR (HEAD: 6e1311b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/637961.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-01-03T00:43:37Z

Message from 蔺林:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/637961.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-03T16:16:32Z

Message from Michael Matloob:

Patch Set 8: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/637961.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-03T16:24:35Z

Message from Michael Matloob:

Patch Set 8: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/637961.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-03T16:24:35Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-01-03T16:04:14Z","revision":"4df4f6fdb6ccb4d76f7f2b4a86da34d827e7bca8"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/637961.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-03T16:32:42Z

Message from Michael Matloob:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/637961.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-03T16:32:43Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/637961.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-03T16:32:43Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/637961.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-03T16:49:22Z

Message from Dmitri Shuralyov:

Patch Set 8: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/637961.
After addressing review feedback, remember to publish your drafts!

When running tests in OpenBSD if 'go' is built with -trimpath, the TestTarget will always fail. Because when invoked without proper environments, 'go' itself fails to find the GOROOT path. Fixes golang/go#70891 Change-Id: I829b77686ae24d869653365f3e44e457c76b46bb GitHub-Last-Rev: 6e1311b GitHub-Pull-Request: #552 Reviewed-on: https://go-review.googlesource.com/c/tools/+/637961 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Michael Matloob <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>

gopherbot · 2025-01-03T17:30:57Z

This PR is being closed because golang.org/cl/637961 has been merged.

linsite force-pushed the fix-test-target branch from 00d5a1c to 4f9dda5 Compare December 27, 2024 10:15

linsite force-pushed the fix-test-target branch from 4f9dda5 to 9bb9bc1 Compare December 27, 2024 10:44

linsite force-pushed the fix-test-target branch from 9bb9bc1 to a190875 Compare December 27, 2024 10:58

linsite force-pushed the fix-test-target branch from a190875 to 9807469 Compare December 27, 2024 11:08

linsite force-pushed the fix-test-target branch from 9807469 to 747c2a0 Compare December 27, 2024 11:18

linsite force-pushed the fix-test-target branch from 747c2a0 to 33df413 Compare December 31, 2024 09:10

go/packages: add GOROOT env to avoid TestTarget failure in OpenBSD

6e1311b

When running tests in OpenBSD if 'go' is built with -trimpath, the TestTarget will always fail. Because when invoked without proper environments, 'go' itself fails to find the GOROOT path. Fixes golang/go#70891

linsite force-pushed the fix-test-target branch from 33df413 to 6e1311b Compare January 3, 2025 00:20

gopherbot closed this Jan 3, 2025

go/packages: add GOROOT env to avoid TestTarget failure in OpenBSD #552

go/packages: add GOROOT env to avoid TestTarget failure in OpenBSD #552

Uh oh!

Conversation

linsite commented Dec 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linsite commented Dec 27, 2024

Uh oh!

gopherbot commented Dec 27, 2024

Uh oh!

gopherbot commented Dec 27, 2024

Uh oh!

gopherbot commented Dec 27, 2024

Uh oh!

gopherbot commented Dec 27, 2024

Uh oh!

gopherbot commented Dec 27, 2024

Uh oh!

gopherbot commented Dec 27, 2024

Uh oh!

gopherbot commented Dec 27, 2024

Uh oh!

gopherbot commented Dec 31, 2024

Uh oh!

gopherbot commented Dec 31, 2024

Uh oh!

gopherbot commented Dec 31, 2024

Uh oh!

gopherbot commented Jan 2, 2025

Uh oh!

gopherbot commented Jan 3, 2025

Uh oh!

gopherbot commented Jan 3, 2025

Uh oh!

gopherbot commented Jan 3, 2025

Uh oh!

gopherbot commented Jan 3, 2025

Uh oh!

gopherbot commented Jan 3, 2025

Uh oh!

gopherbot commented Jan 3, 2025

Uh oh!

gopherbot commented Jan 3, 2025

Uh oh!

gopherbot commented Jan 3, 2025

Uh oh!

gopherbot commented Jan 3, 2025

Uh oh!

gopherbot commented Jan 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

linsite commented Dec 27, 2024 •

edited

Loading